-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Alert)!: Move icon into strong left border and require header #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
demo-DES-1101-update-alert-border-design
December 16, 2024 13:51
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-1101-update-alert-border-design
January 12, 2025 21:54
Destroyed
# Conflicts: # proprietary/tokens/src/components/ams/alert.tokens.json
VincentSmedinga
force-pushed
the
feat/DES-1101-update-alert-border-design
branch
from
January 15, 2025 16:17
8bb0fdd
to
c7678ea
Compare
github-actions
bot
temporarily deployed
to
demo-DES-1101-update-alert-border-design
January 15, 2025 16:17
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-1101-update-alert-border-design
January 16, 2025 07:06
Destroyed
alimpens
reviewed
Jan 17, 2025
# Conflicts: # packages/css/src/components/alert/alert.scss
As designed: the border width is to be subtracted from the padding.
github-actions
bot
temporarily deployed
to
demo-DES-1101-update-alert-border-design
January 21, 2025 09:41
Destroyed
The vertical gap between the items is too large in this context. And this specific example is to be done with Form Error List now.
github-actions
bot
temporarily deployed
to
demo-DES-1101-update-alert-border-design
January 21, 2025 10:30
Destroyed
VincentSmedinga
changed the title
feat!: Move alert icon into thick left border
feat!: Move alert icon into strong left border
Jan 21, 2025
VincentSmedinga
changed the title
feat!: Move alert icon into strong left border
feat(Alert)!: Move icon into strong left border
Jan 21, 2025
alimpens
reviewed
Jan 22, 2025
github-actions
bot
temporarily deployed
to
demo-DES-1101-update-alert-border-design
January 22, 2025 10:32
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-1101-update-alert-border-design
January 22, 2025 13:02
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-1101-update-alert-border-design
January 22, 2025 13:04
Destroyed
alimpens
approved these changes
Jan 22, 2025
VincentSmedinga
changed the title
feat(Alert)!: Move icon into strong left border
feat(Alert)!: Move icon into strong left border and require header
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
Updates the design of Alert:
Additionally, ‘info’ is now the default severity, which has slightly changed the API and removes the need for a second class to be added at all times.
Why
The design has changed to make Alerts more prominent while adhering to the requirements of the current branding.
How
n/a
Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes
; a PR for this will follow.A default severity has not defined yet. Omitting its class name (using onlyams-alert
) renders an Alert with a black outline. UX indicates that the ‘info’ severity should be the default. A PR for this will follow.PRs will also follow to remove the incorrect example of the list in an Alert, and new tickets will be added to the backlog to design for this.