Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Alert)!: Move icon into strong left border and require header #1792

Merged
merged 20 commits into from
Jan 22, 2025

Conversation

VincentSmedinga
Copy link
Contributor

@VincentSmedinga VincentSmedinga commented Dec 16, 2024

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

Updates the design of Alert:

  • The left border has become thick, and the severity icon has moved into it.
  • The header is now required, enabling a simpler layout that allows the description to flow entirely to the right edge.

Additionally, ‘info’ is now the default severity, which has slightly changed the API and removes the need for a second class to be added at all times.

Why

The design has changed to make Alerts more prominent while adhering to the requirements of the current branding.

How

n/a

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • UX agrees that the title of an Alert can be made required. This simplifies the placement of the close button ; a PR for this will follow.
  • A default severity has not defined yet. Omitting its class name (using only ams-alert) renders an Alert with a black outline. UX indicates that the ‘info’ severity should be the default. A PR for this will follow.
  • PRs will also follow to remove the incorrect example of the list in an Alert, and new tickets will be added to the backlog to design for this.

@github-actions github-actions bot temporarily deployed to demo-DES-1101-update-alert-border-design December 16, 2024 13:51 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1101-update-alert-border-design January 12, 2025 21:54 Destroyed
@VincentSmedinga VincentSmedinga requested a review from dlnr January 14, 2025 14:43
@VincentSmedinga VincentSmedinga marked this pull request as draft January 15, 2025 10:01
@VincentSmedinga VincentSmedinga force-pushed the feat/DES-1101-update-alert-border-design branch from 8bb0fdd to c7678ea Compare January 15, 2025 16:17
@github-actions github-actions bot temporarily deployed to demo-DES-1101-update-alert-border-design January 15, 2025 16:17 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1101-update-alert-border-design January 16, 2025 07:06 Destroyed
@VincentSmedinga VincentSmedinga marked this pull request as ready for review January 16, 2025 07:10
@VincentSmedinga VincentSmedinga requested a review from a team as a code owner January 16, 2025 07:10
packages/react/src/Alert/Alert.tsx Outdated Show resolved Hide resolved
packages/css/src/components/alert/alert.scss Outdated Show resolved Hide resolved
packages/css/src/components/alert/alert.scss Outdated Show resolved Hide resolved
packages/css/src/components/alert/alert.scss Outdated Show resolved Hide resolved
packages/css/src/components/alert/alert.scss Show resolved Hide resolved
packages/css/src/components/alert/alert.scss Show resolved Hide resolved
proprietary/tokens/src/components/ams/alert.tokens.json Outdated Show resolved Hide resolved
@alimpens alimpens enabled auto-merge (squash) January 17, 2025 15:03
@github-actions github-actions bot temporarily deployed to demo-DES-1101-update-alert-border-design January 21, 2025 09:41 Destroyed
The vertical gap between the items is too large in this context. And this specific example is to be done with Form Error List now.
@github-actions github-actions bot temporarily deployed to demo-DES-1101-update-alert-border-design January 21, 2025 10:30 Destroyed
@VincentSmedinga VincentSmedinga changed the title feat!: Move alert icon into thick left border feat!: Move alert icon into strong left border Jan 21, 2025
@VincentSmedinga VincentSmedinga changed the title feat!: Move alert icon into strong left border feat(Alert)!: Move icon into strong left border Jan 21, 2025
@github-actions github-actions bot temporarily deployed to demo-DES-1101-update-alert-border-design January 22, 2025 10:32 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1101-update-alert-border-design January 22, 2025 13:02 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1101-update-alert-border-design January 22, 2025 13:04 Destroyed
@alimpens alimpens merged commit ec53af7 into develop Jan 22, 2025
6 checks passed
@alimpens alimpens deleted the feat/DES-1101-update-alert-border-design branch January 22, 2025 13:25
@VincentSmedinga VincentSmedinga changed the title feat(Alert)!: Move icon into strong left border feat(Alert)!: Move icon into strong left border and require header Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants